fix: add 30s request timeout to withSpinner to prevent hanging CLI commands#237
Draft
bukinoshita wants to merge 1 commit intomainfrom
Draft
fix: add 30s request timeout to withSpinner to prevent hanging CLI commands#237bukinoshita wants to merge 1 commit intomainfrom
bukinoshita wants to merge 1 commit intomainfrom
Conversation
…mmands Adds a withTimeout utility that wraps SDK call promises with a 30-second deadline. When the timeout expires, the promise rejects with a structured error that flows through the existing error handling in withSpinner. This prevents contact commands (and all other SDK-backed commands) from hanging indefinitely when the upstream API is slow or unresponsive. Resolves BU-640 Co-authored-by: Bu Kinoshita <bukinoshita@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Add a 30s request timeout to
withSpinnerso CLI commands fail fast instead of hanging when the API is slow. Addresses BU-640 by preventing contact commands from blocking CI jobs.withTimeoututility withREQUEST_TIMEOUT_MS = 30_000.withSpinnerwith the timeout; allwithSpinner-based commands are now bounded.withTimeoutand timeout handling inwithSpinner.Written for commit 6d98a55. Summary will update on new commits.